Revert to the file-based keychain (fix auto-logout / can't sign in)#21
Merged
Conversation
The data-protection keychain change logged users out: once a token was migrated into the data-protection keychain and the file-based copy removed, a later launch could not read it back, so the app fell to onboarding and re-login would not stick (sign-in stored and read through the same failing path). The original file-based keychain worked for both the app and the File Provider extension (same-team partition). The data-protection change was based on a misdiagnosis — the extension's "signed out" state was the App Group database access, not the keychain — so revert it. Users whose token was migrated will sign in once more; it then persists.
Nightly BuildDownload Findle Nightly (unsigned) Built from 5360de5. Important This build is unsigned. macOS will block it on first launch. To open it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build 33 auto-logs-out and won't let the user sign back in. Cause: the data-protection keychain change (PR #18). Once a token was migrated into the data-protection keychain and the file-based copy deleted, a later launch couldn't read it back —
retrieveTokenreturned nil, the app dropped to onboarding, and re-login didn't persist (sign-in stores and reads through the same failing path). Confirmed on the affected machine: file-based keychain empty, account still present, app logged out.Fix
Revert
KeychainManagerto the original file-based implementation, which worked for both the app and the File Provider extension (same-team partition). PR #18 was based on a misdiagnosis — the extension's "signed out" state was App Group database access (EPERM), not the keychain.After updating, users whose token was migrated sign in once more; it then persists. Combined with the DB-in-state-directory fix already on main, this restores the original proven configuration (state-directory DB + file-based keychain) plus the disk-I/O safeguard and What's New-per-build.
Build
Compiles clean (app + extension + MCP).